D27442: fix(kcm): Use explicit Kirigami.Units over singleton from a theme

David Edmundson noreply at phabricator.kde.org
Sun Feb 16 18:54:21 GMT 2020


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  units lowercase is defined by
  
  PlasmaCore as a singleton (which we generally shouldn't be using)
  Kirigami's desktop theme plugin, as a singleton. This plugin is only
  loaded on KDE
  
  Kirigami.Units is the correct import that is always defined.
  
  BUG: 417316

TEST PLAN
  opened KCM normally and with forced QT_QPA_PLATFORM

REPOSITORY
  R104 KScreen

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27442

AFFECTED FILES
  kcm/package/contents/ui/Output.qml
  kcm/package/contents/ui/Screen.qml
  kcm/package/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200216/bd2a6ab6/attachment.html>


More information about the Plasma-devel mailing list