D27420: [Applet]Improvements for unavailable port.

[George Vogiatzis]

gvgeo added a comment.


  > ...it solves the reporter's problem...
  
  Not exactly. When an available port gets selected(or is active) port option will disappear again. Only enables complete port selection while an unavailable is the default.
  
  > Or has the code diverged between 5.18 and master too much?
  
  Yeah, too many patches. In master, you know, we changed the UI, limited the port selection...  :D

INLINE COMMENTS

> ListItemBase.qml:357
> +                            if (port.name == "analog-output-speaker" || port.name == "analog-input-microphone-internal") {
> +                                menuItem.text += i18nc("Port is unavailable", " (unavailable)");
> +                            } else {

I wanted to do this change, but this is old code from 5.17.  I believe that translated history must exist, and will automatically be used.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  freeThePort (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27420

To: gvgeo, #plasma, drosca, ngraham
Cc: pino, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200216/15d220a1/attachment.html>