D27422: [KCM]Always allow port selection

George Vogiatzis noreply at phabricator.kde.org
Sat Feb 15 12:53:34 GMT 2020


gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Add extra row for port combobox.
  Limit combobox's size to fit inside the row.
  Set device icon size huge. Unifies the size which was based on row height.

TEST PLAN
  Before:
  Was not possible to select an unavailable port.
  Combobox could drive the default button out of the layout.
  After:
  Combobox row appears for devices that have at least two ports.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  kcmports (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27422

AFFECTED FILES
  src/kcm/package/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200215/aceb56b9/attachment.html>


More information about the Plasma-devel mailing list