D27391: [Applet]Fix dimensions of traffic Monitor

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> TrafficMonitor.qml:40
>                  top: parent.top
> -                topMargin: Math.round(units.gridUnit / 3) + (index * plotter.height / 5)
> +                topMargin: index * plotter.height / 5
>              }

Always `Math.round` when you doing random fractions of sizes

> TrafficMonitor.qml:43
> +            // Workaround to get paintedHeight.
> +            height: theme.mSize(theme.smallestFont).height
>              font.pointSize: theme.smallestFont.pointSize

You can set it to `undefiend` to reset the height

> TrafficMonitor.qml:61
>              top: parent.top
> -            topMargin: units.gridUnit
> +            topMargin: theme.mSize(theme.smallestFont).height / 2
>          }

Ideally we didn't randomly divide random sizes

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D27391

To: gvgeo, #plasma, #vdg, jgrulich
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200214/cb0e6135/attachment-0001.html>