D27386: Set toolbox to invisble when it's invisible

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  opacity was bound to editMode, but this did not affect visibility or
  enabled.
  
  Not only is this somewhat wasteful, enabled is very important as
  otherwise shortcuts for buttons get intercepted to match the accelerator
  applied to the internal buttons. This breaks all the multi-key shortcuts
  that plasma uses as alt+d gets taken.
  
  BUG: 416695
  FIXED-IN: 5.18.1

TEST PLAN
  Mad gammaray skillz to find the bug
  
  Checked alt+d, a now opens the widget explorer
  Checked edit mode through the context menu still showed the toolbox

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27386

AFFECTED FILES
  toolboxes/desktoptoolbox/contents/ui/ToolBoxButton.qml
  toolboxes/desktoptoolbox/contents/ui/ToolBoxRoot.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200213/0c21a666/attachment.html>