D27024: Solid-device-automounter/kcm: show disconnected known device when disconnecting it

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> DeviceModel.cpp:101
>          // is no longer available when the device is gone
> +        // Unless we have some settings for the device
> +        if (AutomounterSettings::knownDevices().contains(udi)){

I think we need a further update of the comment, indeed it starts with "the device is not moved to"... but clearly not it is. I'd probably revert it with something like "We move the device for the disconnected section only if..." with then further explanations (some of the points mentioned can be kept). In its current form it's just more confusing

> DeviceModel.cpp:102
> +        // Unless we have some settings for the device
> +        if (AutomounterSettings::knownDevices().contains(udi)){
> +            beginInsertRows(index(1, 0), m_disconnected.size(), m_disconnected.size());

Missing space before {

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27024

To: meven, broulik, #plasma, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200212/34b79091/attachment-0001.html>