D27322: Allow move or add window to Activities during Dnd using Ctrl modifier

[Will Stephenson]

wstephenson created this revision.
wstephenson added reviewers: davidedmundson, Plasma, hein.
wstephenson added a project: Plasma.
Herald added a subscriber: plasma-devel.
wstephenson requested review of this revision.

REVISION SUMMARY
  This allows the familiar file manager semantics of ctrl+drag = copy,
  drag = move to be used when dragging and dropping windows between
  activities using the taskbar and the activity pager applet.

TEST PLAN
  - Move window between activities
  - Setup desktop with two activities, taskbar and activity pager, test window on one activity, activate activity with the window on it
  - Drag window's taskbar entry to the other activity's pager item.
  - Observe window moves to other activity
  
  - Add window to another activity
  - Setup remaining from previous test
  - Ctrl-drag window's taskbar entry to the other activity's pager item.
  - Observe window is now on all activities
  
  - Move window from all activities to a single activity
  - Setup remaining from previous test. Window is on all activities
  - Drag window's taskbar entry to an activity pager item
  - Observe window is now only on one activity
  
  - Add window to two out of three activities
  - Setup remaining from previous test. Window is on 1/2 activities
  - Add 3rd activity using Activity Manager
  - Ctrl-drag window's taskbar entry to the new activity.
  - Observe window is now on 2/3 activities
  
  - Move window to a different 2/3 activities
  - Setup remaining from previous test. Window is on 2/3 activities
  - Activate an activity the window is present on
  - Drag window's taskbar entry to the activity it is not on
  - Observe window is now moved to the activity it was dropped on, and is no longer on the current activity
  
  - Add window to the only activity it is not on
  - Setup remaining from previous test. Window is on 2/3 activities
  - Activate an activity the window is present on
  - Ctrl-drag window's taskbar entry to the activity it is not on
  - Observe window is now present on all activities

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27322

AFFECTED FILES
  applets/pager/package/contents/ui/main.qml
  applets/pager/plugin/pagermodel.cpp
  applets/pager/plugin/pagermodel.h

To: wstephenson, davidedmundson, #plasma, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200211/24972d8c/attachment.html>