D27319: Fix dragging windows from taskbar to activity pager applet to add to activity

[Will Stephenson]

wstephenson created this revision.
wstephenson added reviewers: hein, davidedmundson.
wstephenson added a project: Plasma.
Herald added a subscriber: plasma-devel.
wstephenson requested review of this revision.

REVISION SUMMARY
  The code to handle a window drag from the taskbar to drop on the
  Activity Pager to add the window to an Activity was broken,
  because the test to see if the drop location is a running activity
  still treated the itemId as an integer indexing into an array of running
  activity indices, rather than an id string that could be a member of the
  list of running activities.
  
    
    This commit fixes that logic and simplifies the no-op return logic.

TEST PLAN
  0) add activity pager widget[to panel]
  
  1. Create 2nd activity
  2. Open a window.
  3. Set that window via the window menu to only appear on the first activity
  4. Check that the 2nd activity is empty
  5. Drag the window's taskbar entry to the pager item for the 2nd activity
  6. check that the dropped window is now also present on the 2nd activity.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27319

AFFECTED FILES
  applets/pager/plugin/pagermodel.cpp

To: wstephenson, hein, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200211/9219c453/attachment.html>