D27277: Properly search for PipeWire libs

Christophe Giboudeaux noreply at phabricator.kde.org
Mon Feb 10 15:12:29 GMT 2020


cgiboudeaux added inline comments.

INLINE COMMENTS

> FindPipeWire.cmake:73
>      NAMES
> +        pipewire-0.3/pipewire/pipewire.h
> +        spa-0.2/spa/param/props.h

this would break includes

> FindPipeWire.cmake:76
> +        # Old PipeWire locations
>          pipewire/pipewire.h
> +        spa/param/props.h

That's still the current way to include it

> FindPipeWire.cmake:79
>      HINTS
>          ${PKG_PipeWire_INCLUDE_DIRS}
> +        ${PKG_Spa_INCLUDE_DIRS}

Use:

  ${PKG_PipeWire_INCLUDE_DIRS}
  ${PKG_PipeWire_INCLUDE_DIRS}/pipewire-0.3

instead.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27277

To: jgrulich, #plasma
Cc: cgiboudeaux, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200210/0fbf5212/attachment-0001.html>


More information about the Plasma-devel mailing list