D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

Aleksei Nikiforov noreply at phabricator.kde.org
Mon Feb 10 10:59:04 GMT 2020


alnikiforov marked an inline comment as done.
alnikiforov added a comment.


  In D27278#608791 <https://phabricator.kde.org/D27278#608791>, @broulik wrote:
  
  > There seem to be a bunch of additional `m_helper.isNull()` that could be ported to be consistent?
  
  
  
  
  In D27278#608814 <https://phabricator.kde.org/D27278#608814>, @broulik wrote:
  
  > What about the `!m_helper.isNull()` checks in `onWakeupFromIdle` and `onIdleTimeout`?
  
  
  Only two remaining ones are calls to `m_helper->startFade()` and `m_helper->stopFade()` functions. Since it looks like it doesn't invoke any DPMS related function calls, I didn't decide yet to update it there too. If you think these conditions should be updated too, I'll add it to this change.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D27278

To: alnikiforov, apol, davidedmundson, broulik
Cc: broulik, plasma-devel, mlcarr, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200210/edf53bf6/attachment.html>


More information about the Plasma-devel mailing list