D27278: Prevent powerdevil from calling DPMS extension calls when DPMS extension isn't present

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Feb 10 10:43:02 GMT 2020


broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  There seem to be a bunch of additional `m_helper.isNull()` that could be ported to be consistent?

INLINE COMMENTS

> powerdevildpmsaction.cpp:196
>          // Inhibition triggered: disable DPMS
> -        if (!m_helper.isNull()) {
> +        if (isSupported())) {
>              m_helper->inhibited();

There's a superfluous parenthesis.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D27278

To: alnikiforov, apol, davidedmundson, broulik
Cc: broulik, plasma-devel, mlcarr, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200210/ee2f6447/attachment.html>


More information about the Plasma-devel mailing list