D27266: [libtaskmanager] Fix shared VirtualDesktopInfo::Private tied to the 1st creator

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  VirtualDesktopInfo::Private is ref counted and shared between N
  VirtualDesktopInfo's.
  
  We were passing the first VirtualDesktopInfo as a parent to
  VirtualDesktopInfo::Private which didn't manage the lifespan or do
  anything useful.
  
  The wayland backend incorrectly used this 'q' object and spanned
  mulitple internal objects and connections to the first object that
  created the shared private instance, leaving us with dangly objects
  inside.
  
  BUG: 415200
  (and possibly several other bugs of wayland task manager not updating
  correctly)

TEST PLAN
  Compiles
  Plasma still loads

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27266

AFFECTED FILES
  libtaskmanager/virtualdesktopinfo.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200209/f6c294fc/attachment.html>