D27205: [Applet]Always get valid device and stream name

Nathaniel Graham noreply at phabricator.kde.org
Fri Feb 7 14:06:50 GMT 2020


ngraham added a reviewer: VDG.
ngraham added inline comments.

INLINE COMMENTS

> DeviceListItem.qml:49
> +        }
> +        return "Device name not found";
>      }

If this is something that should be shown to the user (is it?), then it needs to be localized by wrapping it in `i18n()`

> StreamListItem.qml:35
> +        }
> +        return "Stream name not found";
> +    }

ditto

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27205

To: gvgeo, #plasma, drosca, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200207/f2fd2c62/attachment.html>


More information about the Plasma-devel mailing list