D27199: [WIP][Applet]Update layout based on T10470
George Vogiatzis
noreply at phabricator.kde.org
Thu Feb 6 19:34:35 GMT 2020
gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, jgrulich, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added 1 blocking reviewer(s): jgrulich.
gvgeo requested review of this revision.
REVISION SUMMARY
Need help/ideas:
Have a problem to disable highlight of List Item when holding the mouse button.
The way to display the line above the available connections is bad. Just hiding active connections section, haven't a better way.
I've added 3 lines with a `// TODO Fix bind loop messages for width.` for 2 pre-existing issues. I tried to solve them, but failed. Note sure if they have place in code.
Thoughts on the layout.
Note: I cannot build. So... I test only the qml changes.
REPOSITORY
R116 Plasma Network Management Applet
BRANCH
layout (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27199
AFFECTED FILES
applet/contents/ui/ConnectionItem.qml
applet/contents/ui/DetailsText.qml
applet/contents/ui/Header.qml
applet/contents/ui/PopupDialog.qml
applet/contents/ui/Toolbar.qml
applet/contents/ui/TrafficMonitor.qml
applet/contents/ui/main.qml
libs/models/networkmodelitem.cpp
To: gvgeo, #plasma, #vdg, jgrulich, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200206/819fbac2/attachment.html>
More information about the Plasma-devel
mailing list