D27198: [RFC] Reduce size of Level 1 headings and increase left padding on page titles
Nathaniel Graham
noreply at phabricator.kde.org
Thu Feb 6 18:45:50 GMT 2020
ngraham created this revision.
ngraham added reviewers: VDG, Kirigami, manueljlin.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Level 1 headings are humongous. The degree of humongousness is maybe a bit excessive,
especially on page titles with toolbars, where it looks like it's positively trying
to burst from its bounds! Also, the left padding could stand to be increased, which
would make the titles align with the content for most views. This was brought up in
T12631 <https://phabricator.kde.org/T12631>.
If this patch is approved, I will submit companion patches to make the same changes in
the PlasmaExtras Heading and KTitleWidget.
TEST PLAN
Discover, before: F8088774: Discover, before.png <https://phabricator.kde.org/F8088774>
Discover, after: F8088773: Discover, after.png <https://phabricator.kde.org/F8088773>
Kirigami Gallery, after: F8088775: In Kirigami Gallery.webm <https://phabricator.kde.org/F8088775>
REPOSITORY
R169 Kirigami
BRANCH
smaller-and-more-left-padded-page-titles (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D27198
AFFECTED FILES
src/controls/Heading.qml
src/controls/private/globaltoolbar/TitlesPageHeader.qml
src/controls/private/globaltoolbar/ToolBarPageHeader.qml
To: ngraham, #vdg, #kirigami, manueljlin
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart, hein
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200206/8113c787/attachment.html>
More information about the Plasma-devel
mailing list