D27182: [applets/taskmanager] Clean up Tooltip code

Tranter Madi noreply at phabricator.kde.org
Thu Feb 6 16:40:03 GMT 2020


trmdi added inline comments.

INLINE COMMENTS

> ToolTipInstance.qml:100
> +        ColumnLayout {
> +            spacing: units.smallSpacing
> +

Could it be zero here? Because `Text` lines already has its own padding, isn't it?

> ngraham wrote in ToolTipInstance.qml:79
> If we do that, then the size of the preview/album art area can get very short, which I don't think is desirable.

Could we have a fixed size rectangle with some ratio?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-up-tooltip-code (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27182

To: ngraham, #plasma, #vdg, ndavis
Cc: trmdi, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200206/9f2034fa/attachment-0001.html>


More information about the Plasma-devel mailing list