D27189: Created a top area based on widgets/toparea.svg

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Yeah, so you'll want to submit a plasma-frameworks patch which includes the new SVG and mark this as depending on it.
  
  The reason why the text is now pushed over is because you added the new `PlasmaCore.FrameSvgItem` *inside* the `RowLayout` that contains the `Heading`. If anything the reverse should be true; the `RowLayout` should be inside the new header SVG.
  
  Also you can't set anchors on an item inside a Layout; it causes binding loops. Anchors are only for positioning items that are outside of Layouts. Items inside Layouts get positioned using properties like `Layout.fillWidth, `Layout.Alignment`, `Layout.maximumWidth`, and so on.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200206/fe81195d/attachment.html>