D27183: Port Application Page's form layout to Kirigami FormLayout

Nathaniel Graham noreply at phabricator.kde.org
Thu Feb 6 05:21:20 GMT 2020


ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This simplifies the code, allows the layout to have a mobile-appropriate appearance
  when there's not much horizontal space, and it's more semantically correct.

TEST PLAN
  There is one regression I haven't figured out: sometimes long labels get inappropriately
  elided.
  
  F8087693: elided.png <https://phabricator.kde.org/F8087693>

REPOSITORY
  R134 Discover Software Store

BRANCH
  port-to-formlayout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27183

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200206/ea27bef0/attachment-0001.html>


More information about the Plasma-devel mailing list