D27166: Refactor converter runner

Alexander Lohnau noreply at phabricator.kde.org
Wed Feb 5 10:56:22 GMT 2020


alex created this revision.
alex added reviewers: broulik, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The logic from the converter runner has been refactored and moved to seperate files.
  Additionally some foreach marcos have been refactored and the numberValue of the query gets only
  calculated once, instead of being calculated for each matching unit.

TEST PLAN
  The plugin should work as before and the fractional units in https://phabricator.kde.org/D22869 are still supported.

REPOSITORY
  R114 Plasma Addons

BRANCH
  converter_runner_refactoring (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27166

AFFECTED FILES
  runners/converter/CMakeLists.txt
  runners/converter/converter_utilities.h
  runners/converter/converterparser.h
  runners/converter/converterrunner.cpp
  runners/converter/converterrunner.h

To: alex, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200205/ba08a163/attachment.html>


More information about the Plasma-devel mailing list