D27143: moved do not disturb to the bottom
Kai Uwe Broulik
noreply at phabricator.kde.org
Wed Feb 5 08:30:51 GMT 2020
broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.
My biggest gripe with merely moving the controls to the bottom is that many plasmoids show additional information in the header, which will cause the controls to shift around and their position unpredictable.
While do not disturb is on the checkbox is further up than normal.
F8086256: Screenshot_20200205_093025.PNG <https://phabricator.kde.org/F8086256>
INLINE COMMENTS
> FullRepresentation.qml:464
> + // until you actually select something :)
> + dndMenu.open(0, 0);
> + }
The menu placement is quite odd now, it should open upwards.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D27143
To: niccolove, ngraham, broulik, #plasma
Cc: filipf, gvgeo, plasma-devel, manueljlin, Orage, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, zachus, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, ngraham, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200205/12f6a8b0/attachment-0001.html>
More information about the Plasma-devel
mailing list