D27160: [mediacontroller] WIP: Visually refresh media controller plasmoid

[George Vogiatzis]

gvgeo added a comment.


  Maybe I'm wrong, don't give too much weight on these comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:212
>  
> -            source: mpris2Source.currentData["Desktop Icon Name"]
> -            visible: !albumArt.visible
> +                        Layout.maximumWidth: expandedRepresentation.width * (2/5)
> +                    }

You are limiting `Details Column`'s width, while `Album Art` is not always visible.

> ExpandedRepresentation.qml:216
> +                        id: songArtist
> +                        visible: root.track && root.artist
> +                        level: 2

With a white theme?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27160

To: cblack, #vdg, #plasma, manueljlin
Cc: gvgeo, davidedmundson, ngraham, manueljlin, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200205/2df89d43/attachment.html>