D27144: Moved toggles to the bottom according to T10470

[Filip Fila]

filipf added a comment.


  In D27144#605649 <https://phabricator.kde.org/D27144#605649>, @ngraham wrote:
  
  > Now when Bluetooth is on but there are no devices, the applet looks like this:
  >
  > F8083748: Screenshot_20200203_150046.png <https://phabricator.kde.org/F8083748>
  >
  > This popup should really be written with layouts instead of anchors; then it would be trivial to just add an item in the middle with `Layout.fillWidth: true` in it. As-is, you'll need to approximate that with anchors.
  >
  > Or you could rewrite it with Layouts first, and then do this afterwards.
  >
  > Your call.
  
  
  That's what I see as well.

INLINE COMMENTS

> Toolbar.qml:34
> +    PlasmaCore.SvgItem {
> +        id: headerSeparator
> +        anchors {

don't need the id

> Toolbar.qml:35
> +        id: headerSeparator
> +        anchors {
> +            top: parent.top

you can just do `anchors.top: ` since it's only 1 anchor

> Toolbar.qml:42
> +        svg: PlasmaCore.Svg {
> +            id: headerSeparatorLine
> +            imagePath: "widgets/line"

probably better to call it toolbarSeparator or footerSeparator here

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D27144

To: niccolove, #plasma, #vdg, ngraham
Cc: filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200204/44ca33ff/attachment.html>