D27079: Don't escape search text in search page title
Aleix Pol Gonzalez
noreply at phabricator.kde.org
Mon Feb 3 17:08:51 GMT 2020
apol added a comment.
Because if you enter `my <u>potato</u>` it gets styled, which shouldn't happen.
I suggest just doing the following:
diff --git a/discover/qml/ApplicationsListPage.qml b/discover/qml/ApplicationsListPage.qml
index 4445a195..e094b667 100644
--- a/discover/qml/ApplicationsListPage.qml
+++ b/discover/qml/ApplicationsListPage.qml
@@ -52,11 +52,8 @@ DiscoverPage {
function escapeHtml(unsafe) {
return unsafe
- .replace(/&/g, "&")
.replace(/</g, "<")
- .replace(/>/g, ">")
- .replace(/"/g, """)
- .replace(/'/g, "'");
+ .replace(/>/g, ">");
}
background: Rectangle {
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D27079
To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200203/96b28f8c/attachment.html>
More information about the Plasma-devel
mailing list