D27134: [Notifications] Don't dodge notification popups

Kai Uwe Broulik noreply at phabricator.kde.org
Mon Feb 3 16:41:34 GMT 2020


broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This wasn't an issue before as notification popups could never have focus.
  However, now with quick reply, they can, leading to funky results and gaps when a notification appears while answering another one.

TEST PLAN
  5.18 please
  
  - Ran `sleep 3; notify-send foo bar` and then spawned a quick reply notification and clicked the text field.
  
  Previously I Would end up with weird situations like this, where the new notification popup would try to avoid the focussed popup, which then would also shift downwards to avoid the other popup, etc
  F8080601: Screenshot_20200203_174039.PNG <https://phabricator.kde.org/F8080601>
  With this patch they are always placed correctly.
  
  They still avoid systray popups and the calendar as before

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27134

AFFECTED FILES
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200203/a96c9434/attachment.html>


More information about the Plasma-devel mailing list