D27131: [Applet]Fix device label problems

George Vogiatzis noreply at phabricator.kde.org
Mon Feb 3 16:14:24 GMT 2020


gvgeo created this revision.
gvgeo added reviewers: Plasma, VDG, drosca, ngraham, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Limit label maximum width, to avoid breaking UI.
  Change label to use plasma components 3, for theme color compatibility.
  Use of implicit sizes, to avoid binding loops.
  
  Note: Didn't make use fillWidth because we need the button area to be
  only on the text, and not in the empty area.

TEST PLAN
  Use applet outside of systemtray and limit it's width.
  If device description is not long enough, enable in the configuration
  "Add virtual output device for simultaneous output on all local sound cars".
  Before: Hamburger menu moves to the right, and there is no eliding.
  After: Proper display.
  
  BUG: 417074
  BUG: 417106

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  labelWidth2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27131

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200203/1ecce3e2/attachment-0001.html>


More information about the Plasma-devel mailing list