D27126: [SNI] Fix race condition in item registration

Konrad Materka noreply at phabricator.kde.org
Mon Feb 3 15:49:23 GMT 2020


kmaterka added inline comments.

INLINE COMMENTS

> statusnotifierwatcher.cpp:69
> +    if (m_registeredServices.contains(notifierItemId)) {
> +        return;
> +    }

Is this OK? Are mid-method returns allowed?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27126

To: kmaterka, #plasma_workspaces, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200203/d43e4f14/attachment.html>


More information about the Plasma-devel mailing list