D27117: [Applet]Fix long device name

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ListItemBase.qml:120
>                          id: defaultButton
> +                        Layout.maximumWidth: controlsRow.width - (clientIcon.visible ? clientIcon.width + units.smallSpacing : 0)
> +                                              - (contextMenuButton.visible ? contextMenuButton.implicitWidth + units.smallSpacing : 0)

This feels wrong. The radio button shouldn't need a maximum width set on it.

> ListItemBase.qml:132
>                          id: soloLabel
> +                        Layout.maximumWidth: defaultButton.Layout.maximumWidth
>                          text: defaultButton.text

Instead of giving this label a maximum width, maybe you could just have it be the item in the layout that gets `Layout.fillWidth: true` and then remove the `Item` below it

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200203/e8547c74/attachment.html>