D27117: [Applet]Fix long device name

George Vogiatzis noreply at phabricator.kde.org
Mon Feb 3 10:18:02 GMT 2020


gvgeo added inline comments.

INLINE COMMENTS

> ListItemBase.qml:111
>                  id: column
> -                spacing: 0
> +                Layout.minimumHeight: contextMenuButton.implicitHeight * 2 + units.smallSpacing
> +                Layout.maximumHeight: Layout.minimumHeight

With testing I found 5 pixel spacing. But couldn't trace where it comes from, maybe padding around items?. Used smallSpacing instead to avoid another magic number.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200203/9364b851/attachment-0001.html>


More information about the Plasma-devel mailing list