D27107: Remove redundant reparse configuration calls

Mikhail Zolotukhin noreply at phabricator.kde.org
Sun Feb 2 19:53:08 GMT 2020


gikari added a comment.


  In D27107#604878 <https://phabricator.kde.org/D27107#604878>, @davidedmundson wrote:
  
  > You need to be careful here.
  >
  > Some of this code is re-evaluated on receipt of other direct DBus signals. Not from kconfigwatcher.
  >
  > In those cases, you will have to reparse.
  
  
  OK, so that makes 90% of this diff pointless :) Only the decorations button order change are triggered by `KConfigWatcher`. Would it make sense to port other methods to be triggered by corresponding `KConfigWatcher`s or would it slow down the whole process of syncing settings significantly?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27107

To: gikari
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200202/5bf11477/attachment-0001.html>


More information about the Plasma-devel mailing list