D26271: [Applet]Update layout based on T10470

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ListItemBase.qml:111
>                  RowLayout {
> -                    Layout.fillWidth: true
> +                    Layout.minimumHeight: contextMenuButton.height
>  

That's asking for a binding loop.

An implicit size should never be based on a current size.

This could be:
Layout.minimumHeight: contextMenuButton.implicitHeight

Though I'm surprised you need this line at all.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: davidedmundson, cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200202/2f111d87/attachment.html>