D27100: Parameterise GTK config editing

Mikhail Zolotukhin noreply at phabricator.kde.org
Sun Feb 2 13:45:27 GMT 2020


gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  This diff is only touches the editing part of the ConfigEditor.
  
  Changes:
  
  1. Pass config values as the respecting types: `int`, `bool` and `string`. This simplifies config editing in some extent - no more hardcoded options names, that requires quotes around values in gtkrc-2.0 and xsettingsd.conf. Also it simplifies working with GSettings API and helps to transform KDE config options to GTK config options.
  2. Remove redundant `\\n` symbols, when adding new option in gtkrc-2.0 and xsettingsd.conf

TEST PLAN
  1. Restart Kded
  2. Test all settings syncing. Specifically boolean ones and enum ones, as the format in configuration files has changed:
  3. `Settings.ini` uses new booleans (`true` and `false` instead of `1` and `0`)
  4. `Settings.ini`, `.gtkrc-2.0` and `xsettingsd.conf` use `int` value of enum instead of `string`

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  parameterise-gtk-config-io (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27100

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200202/894ba566/attachment.html>


More information about the Plasma-devel mailing list