D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex marked an inline comment as done.
alex added a comment.


  Hello,
  thanks for the response.
  
  I addition to your requested change  I have made some smaller improvements.
  
  But I have a question about the concept of this runner: Why is the data for every match session newly created ? I understand that it saves a bit of memory to delete them, but this way the spellers are for every match session created
  (and the prepare/teardown slots are called in the main thread).
  
  What do you think about loading the data in the reloadConfiguration method and then reusing it ?
  This way the spellers for new languages can be also reused for multiple match sessions (they are in the match method created).
  
  PS: When I tested this plugin I found out that the "task-attention" icon for the error message (line 252 in the runner) is no longer available, but I don't know which icon would be a good replacement.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200201/e02df0c3/attachment.html>