D29308: Fix excessive right padding in scrollable page

Nicolas Fella noreply at phabricator.kde.org
Thu Apr 30 18:46:31 BST 2020


nicolasfella created this revision.
nicolasfella added reviewers: Kirigami, mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  In this example
  
    import QtQuick 2.5
    import QtQuick.Layouts 1.1
    import org.kde.kirigami 2.4 as Kirigami
    
    Kirigami.ScrollablePage {
    
        Rectangle {
            width: parent.width
            height: 1000
            color: "red"
        }
    }
  
  the gap between the rectangle and the scrollbar was larger than the distance between the left edge of the rectangle and the window. This was caused by the extra rightPadding of the RefreshableScrollView. It also seems unnecessary to me since the ScrollView itself takes care of dodging the scroll bar (ScrollView.qml:21).

REPOSITORY
  R169 Kirigami

BRANCH
  margin

REVISION DETAIL
  https://phabricator.kde.org/D29308

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: nicolasfella, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200430/c432a36f/attachment.html>


More information about the Plasma-devel mailing list