D29297: [Notifications] Have checkIndex check if the index is valid
Kai Uwe Broulik
noreply at phabricator.kde.org
Thu Apr 30 14:56:47 BST 2020
broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.
REVISION SUMMARY
Apparently by default it only considers "out of range" indices invalid but an invalid one as valid.
TEST PLAN
5.18?
- Closing notifications still works
- Pausing, aborting jobs still works
Possibly fixes Bug 418347 or some other unexpected crashers?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D29297
AFFECTED FILES
libnotificationmanager/jobsmodel.cpp
libnotificationmanager/notificationsmodel.cpp
To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200430/493e686b/attachment.html>
More information about the Plasma-devel
mailing list