D29285: KCM Icons : Use KIconloader::emitChange() instead of deprecated newIconLoader()

[Cyril Rossi]

crossi added a comment.


  In D29285#660158 <https://phabricator.kde.org/D29285#660158>, @broulik wrote:
  
  > Can this go into 5.18?
  
  
  Sure.

INLINE COMMENTS

> broulik wrote in main.cpp:307
> Isn't this redundant? i.e. doesn't `emitChange` emit do exactly this?

This one sends a `notifyChange` signal.

`KIconLoader::emitChange()` sends a `iconChanged()` signal.

From KIconLoader :

  QDBusMessage message = QDBusMessage::createSignal(QStringLiteral("/KIconLoader"), QStringLiteral("org.kde.KIconLoader"), QStringLiteral("iconChanged"));

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29285

To: crossi, #plasma, bport, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200430/d762dd20/attachment-0001.html>