D29279: Don't play volume feedback if max volume is reached

Nicolas Fella noreply at phabricator.kde.org
Wed Apr 29 17:01:21 BST 2020


nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  I often smash my volume up key until the volume is max. I usually smash it for too long and the sound is still playing even if the volume isn't actually changing any more. By not playing a sound when the volume is already at maximum we avoid a weird sound and give an accoustic feedback that the maximum has been reached.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  vol

REVISION DETAIL
  https://phabricator.kde.org/D29279

AFFECTED FILES
  applet/contents/ui/main.qml

To: nicolasfella, #plasma, drosca
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200429/2fc90355/attachment.html>


More information about the Plasma-devel mailing list