D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

Benjamin Port noreply at phabricator.kde.org
Wed Apr 29 14:57:10 BST 2020


bport accepted this revision.
bport added a comment.


  OK for me, as long as VDG is ok with this behavior

INLINE COMMENTS

> fonts.cpp:272
> +        const int generalFontPointSize = font.pointSize();
> +        if (generalFontPointSize > 8) {
> +            smallestFont.setPointSize(generalFontPointSize - 2);

Nit-pick can we align comment and code either higher than 8pt (comment) or >= 9 on the code

REPOSITORY
  R119 Plasma Desktop

BRANCH
  make-small-font-smaller-when-changing-all-font-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200429/fbf8f0a8/attachment.html>


More information about the Plasma-devel mailing list