D29135: PageRouter: find parents of items better

Marco Martin noreply at phabricator.kde.org
Tue Apr 28 17:13:25 BST 2020


mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> pagerouter.cpp:342
> +            auto casted = qobject_cast<PageRouter*>(pointer);
> +            if (casted != nullptr) return casted;
> +            pointer = pointer->parent();

as frameworks style guidelines, always even for oneliners
if () {
}

REPOSITORY
  R169 Kirigami

BRANCH
  cblack/better-router-parent-finding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29135

To: cblack, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200428/ea9188f2/attachment.html>


More information about the Plasma-devel mailing list