D29156: [kcms/fonts] When adjusting all fonts, keep Small font size smaller

Ahmad Samir noreply at phabricator.kde.org
Tue Apr 28 16:09:49 BST 2020


ahmadsamir added inline comments.

INLINE COMMENTS

> fonts.cpp:271
> +        // tiny, they want a tiny font everywhere.
> +        if (font.pointSize() > 8) {
> +            smallestFont.setPointSize(font.pointSize() - 2);

Nit-pick: I'd store font.pointSize() in a const int, and use that instead of calling pointSize() more than once.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29156

To: ngraham, #plasma, ahmadsamir, bport
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200428/62595d16/attachment-0001.html>


More information about the Plasma-devel mailing list