D29234: Fix various bugs introduced with heading

Kai Uwe Broulik noreply at phabricator.kde.org
Tue Apr 28 16:03:42 BST 2020


broulik added inline comments.

INLINE COMMENTS

> niccolove wrote in NotificationItem.qml:125
> I originally did this but I had a problem. It displays and works just as good, but it will throw a "you are using anchors in layouts" error in the console. Even though I disable the anchors in the propertychanges, it seems like the property is updated after throwing the error.

hm, ok

> niccolove wrote in NotificationItem.qml:139
> Why shouldn't it be necessary?  PlasmoidHeading inherits from the Control element, which does not let click events through according to the documentation, so I thought I'd need to catch them on top of it.
> 
> Regarding the close button unusable, it's due to the order of the elements, I'll fix it immediately

> inherits from the Control element, which does not let click events through

urgh, really?! Then we can't use it here. I will not accept having two competing `MouseArea`s doing the same thing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200428/47d79aaa/attachment.html>


More information about the Plasma-devel mailing list