D29154: Use QWindow overload of QIcon::pixmap

David Redondo noreply at phabricator.kde.org
Sat Apr 25 10:03:16 BST 2020


davidre added a comment.


  In D29154#656690 <https://phabricator.kde.org/D29154#656690>, @apol wrote:
  
  > This is what it looks like for me with the patch applied.
  >
  > scale 1x: F8258193: Screenshot_20200424_203628.png <https://phabricator.kde.org/F8258193>
  >  scale 2x: F8258201: Screenshot_20200424_203729.png <https://phabricator.kde.org/F8258201>
  >
  > master:
  >  scale 1x: F8258205: Screenshot_20200424_203923.png <https://phabricator.kde.org/F8258205>
  >  scale 2x:F8258207: Screenshot_20200424_203959.png <https://phabricator.kde.org/F8258207>
  >
  > I can see a noticeable wonky-ness on 1x master, so I'd say this patch helps.
  
  
  Is master scale 1x the correct image? Also  notice the network icon looks bad at 2x in both images

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29154

To: davidre, apol, broulik, ndavis, #breeze, davidedmundson, cblack
Cc: cblack, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200425/7f15adcb/attachment.html>


More information about the Plasma-devel mailing list