D29144: [applets/weather] Improve UX for selecting a weather station

[Kai Uwe Broulik]

broulik added a comment.


  +1 that hidden flag thing always bugged me

INLINE COMMENTS

> WeatherStationPicker.qml:66
> +        ColumnLayout {
> +            Kirigami.FormData.label: i18n("Select weather providers:")
> +            Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater

Perhaps just "Weather Providers:"?

> WeatherStationPicker.qml:67
> +            Kirigami.FormData.label: i18n("Select weather providers:")
> +            Kirigami.FormData.buddyFor: children[1] // 0 is the Repeater
> +

How about `calendarPluginsRepeater.itemAt(0)`

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29144

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200423/8c676434/attachment.html>