D29132: [applet] Show toolbar unless Bluetooth hardware is absent
Nathaniel Graham
noreply at phabricator.kde.org
Thu Apr 23 14:45:41 BST 2020
ngraham created this revision.
ngraham added reviewers: VDG, niccolove, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
While testing other bluedevil patches, I was finding that the toolbar showing and hiding
itself when bluetooth is turned on and off was feeling a bit weird to me. This patch
makes the toolbar always visible as long as a Bluetooth adapter is present; effectively
this means that the toolbar no longer disappears when bluetooth is disabled. Instead,
the toolbar remains visible but its controls are all disabled.
If nobody likes this, I can drop it, but wanted to present the idea. If we like this,
I would propose doing the same for other applets with toolbars so that they aren't
appearing and disappearing so much.
TEST PLAN
F8255623: vokoscreenNG-2020-04-23_07-41-35.webm <https://phabricator.kde.org/F8255623>
REPOSITORY
R97 Bluedevil
BRANCH
almost-always-show-applet-toolbar (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29132
AFFECTED FILES
src/applet/package/contents/ui/FullRepresentation.qml
To: ngraham, #vdg, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200423/f101682f/attachment.html>
More information about the Plasma-devel
mailing list