D29127: Account for top and bottom margin in default card height

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This makes Card account for the negative top and bottom margin when used
  in its default Banner height. In addition, only add top and bottom
  padding when there is a content item. This ensures that cards without
  contents have a correct default height that doesn't leave any gaps at
  the bottom.
  
  Most prominently, this removes the need for any height specification in
  the new Kirigami Gallery main page and fixes the cards' height when
  displaying only one column.

TEST PLAN
  All cards in Kirigami Gallery display correctly now.

REPOSITORY
  R169 Kirigami

BRANCH
  cardheight

REVISION DETAIL
  https://phabricator.kde.org/D29127

AFFECTED FILES
  src/controls/Card.qml
  src/controls/templates/AbstractCard.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200423/5e7aaf3a/attachment.html>