D29116: [applets/batterymonitor] Put the toolbar in the header area
Nathaniel Graham
noreply at phabricator.kde.org
Thu Apr 23 05:02:15 BST 2020
ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik, niccolove, manueljlin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
This patch implements part of the mockup at T10470 <https://phabricator.kde.org/T10470> by putting the power management
checkbox and settings button in a heading area visually connected to the titlebar.
In the process, I fixed a problem with the power management checkbox to make the layout's
spacing work: the checkbox now has text of its own, instead of living in a mouse area
with a separate label.
TEST PLAN
F8254807: Battery monitor.png <https://phabricator.kde.org/F8254807>
F8254808: Gets a bit chunky.png <https://phabricator.kde.org/F8254808>
REPOSITORY
R120 Plasma Workspace
BRANCH
give-battery-applet-a-header (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D29116
AFFECTED FILES
applets/batterymonitor/package/contents/ui/PopupDialog.qml
applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
To: ngraham, #vdg, #plasma, broulik, niccolove, manueljlin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200423/de599917/attachment-0001.html>
More information about the Plasma-devel
mailing list