D29092: Various fixes to new Cards

Arjen Hiemstra noreply at phabricator.kde.org
Wed Apr 22 13:34:11 BST 2020


ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This contains various small fixes to the new Cards.
  
  - Still show the border of AbstractCard on Cards with images.
  - Round bottom corners of the banner when the card doesn't have any other contents.
  - Don't use fwidth for smoothing, instead just use a fixed value, this increases the accuracy of lines rendered by cards.
  - Fix batching test for ShadowedTexture, prevents cards being rendered with the wrong texture.

TEST PLAN
  The new Kirigami Gallery displays more correct now, though there are some layout issues that are not regressions.

REPOSITORY
  R169 Kirigami

BRANCH
  cards_fixes

REVISION DETAIL
  https://phabricator.kde.org/D29092

AFFECTED FILES
  src/controls/Card.qml
  src/controls/private/BannerImage.qml
  src/scenegraph/shaders/sdf.glsl
  src/scenegraph/shadowedbordertexturematerial.cpp
  src/scenegraph/shadowedtexturematerial.cpp

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, ahiemstra, davidedmundson, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200422/eb141800/attachment.html>


More information about the Plasma-devel mailing list