D28509: RFC: [libnotificationmanager] introduce the notification watcher

[Bhushan Shah]

bshah added inline comments.

INLINE COMMENTS

> broulik wrote in notification.h:128
> Maybe add a new `rawHints() const`?
> 
> Not a fan of ref return

I avoided using "raw" word in the function name, because when we process hints we don't actually modify it. We just process rest of notifications data, so it is still same thing.

I will drop ref return however.

> broulik wrote in server_p.cpp:232
> Can you use generated XML interface for this, maybe?

It would introduce weird dependency loop so I'd rather not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28509

To: bshah, #plasma, broulik, davidedmundson
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200422/90d051d7/attachment.html>