D28625: Use ShadowedRectangle for Card backgrounds

Carson Black noreply at phabricator.kde.org
Tue Apr 21 21:29:23 BST 2020


cblack added a comment.


  This seems to be causing regressions to card behaviour for me.
  
  Cards are running together when they weren't previously:
  F8252161: ksnip_20200421-162339.png <https://phabricator.kde.org/F8252161>
  
  The images are:
  
  1. having non-deterministic texture issues (amdgpu/Mesa)
  2. getting distorted when they previously weren't
  
  F8252164: ksnip_20200421-162514.png <https://phabricator.kde.org/F8252164>
  
  Additionally, this appears to be having a non-trivial performance regression to large amounts of cards, as Ikona will freeze for much longer with this patch in its Icon Browser than without cards.
  
  Additionally, console output spams something like this when cards are involved:
  
    /usr/lib64/qml/org/kde/kirigami.2/AbstractCard.qml:31: TypeError: Type error (file:////usr/lib64/qml/org/kde/kirigami.2/AbstractCard.qml:31, )

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28625

To: ahiemstra, #kirigami, #vdg, cblack, mart
Cc: mart, ngraham, nicolasfella, cblack, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, ahiemstra, davidedmundson
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200421/e98f57b0/attachment.html>


More information about the Plasma-devel mailing list