D28141: Add KSysGuard::Sensors library

Marco Martin noreply at phabricator.kde.org
Tue Apr 21 11:24:11 BST 2020


mart added inline comments.

INLINE COMMENTS

> Sensor.cpp:207
> +
> +    if(parent() && parent()->metaObject()->indexOfSignal("enabledChanged()") != -1) {
> +        connect(parent(), SIGNAL(enabledChanged()), this, SIGNAL(enabledChanged()));

if (

> SensorDaemonInterface.cpp:87
> +    auto watcher = new QDBusPendingCallWatcher{d->dbusInterface->sensorData({sensorId}), this};
> +    connect(watcher, &QDBusPendingCallWatcher::finished, watcher, [=](QDBusPendingCallWatcher *self) {
> +        self->deleteLater();

also here, [this] instead of [=]

> SensorsPlugin.cpp:2
>  /*
> -    Copyright (C) 2019 Vlad Zagorodniy <vladzzag at gmail.com>
> +    Copyright (C) 2020 Arjen Hiemstra <ahiemstra at heimr.nl>
>  

also here

> SensorsPlugin.h:2
>  /*
> -    Copyright (C) 2019 Vlad Zagorodniy <vladzzag at gmail.com>
> +    Copyright (C) 2020 Arjen Hiemstra <ahiemstra at heimr.nl>
>  

shouldn't remove existing copyrights?

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D28141

To: ahiemstra, #plasma
Cc: mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200421/2a68cb1e/attachment-0001.html>


More information about the Plasma-devel mailing list