D28333: Add a new daemon for stats monitoring

[Ivan Čukić]

ivan added inline comments.

INLINE COMMENTS

> main.cpp:45
> +        m_property1->setMin(0);
> +        m_property1->setMin(100);
> +        m_property1->setShortName("Some Sensor 1");

`setMax`?

> client.cpp:38
> +{
> +    connect(m_daemon, &KSysGuardDaemon::sensorRemoved, this, [=](const QString &sensor) {
> +        m_subscribedSensors.remove(sensor);

s/=/this/

http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0806r2.html

> client.cpp:56
> +        auto sensor = m_daemon->findSensor(sensorPath);
> +        if (sensor) {
> +            m_connections[sensor] = connect(sensor, &SensorProperty::valueChanged, this, [this, sensor]() {

Maybe:

  if(auto sensor = m_daemon->findSensor(sensorPath)) {
      ...
  }

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28333

To: davidedmundson, #plasma
Cc: ivan, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20200421/0ebd3a60/attachment.html>